[prev] [thread] [next] [lurker] [Date index for 2006/03/31]
simon@xxxxxxx.xxxxxxxxx.xxx wrote:
> Author: simon
> Date: 2006-03-31 11:48:03 +0100 (Fri, 31 Mar 2006)
> New Revision: 1969
>
> Modified:
> trunk/Email-Folder/lib/Email/Folder/Mbox.pm
> Log:
> Fixed clobbering of $/ as per
>
> https://rt.cpan.org/Ticket/Display.html?id=17951 as per perl@xxxxxx.xxx
Bug the bug is that it clobbers $_. Your patch really wouldn't fix that
and instead SLURPS THE GODDAMN FILE.
>
>
>
> Modified: trunk/Email-Folder/lib/Email/Folder/Mbox.pm
> ===================================================================
> --- trunk/Email-Folder/lib/Email/Folder/Mbox.pm 2006-02-01 16:52:17 UTC (rev 1968)
> +++ trunk/Email-Folder/lib/Email/Folder/Mbox.pm 2006-03-31 10:48:03 UTC (rev 1969)
> @@ -95,6 +95,7 @@
>
> local $/ = $self->{eol};
> my $fh = IO::File->new($file) or croak "Cannot open $file";
> + binmode($fh);
>
> if ($self->{seek_to}) {
> # we were told to seek. hope it all goes well
> @@ -124,6 +125,7 @@
> my $inheaders = 1;
> ++$count;
> print "$count starting scanning at line $.\n" if debug;
> + local $/;
> while (<$fh>) {
> if ($_ eq $/ && $inheaders) { # end of headers
> print "$count end of headers at line $.\n" if debug;
>
--
Richard Clamp <richardc@xxxxxxxxx.xxx>
Generated at 06:00 on 10 Jun 2006 by mariachi 0.52