[prev] [thread] [next] [lurker] [Date index for 2002/09/11]
On Tue, Sep 10, 2002 at 09:05:22PM +0100, Richard Clamp said: > And ensuring that subscriptions can happen from the wire. Yeah, that too. Did you say that you were going to handle the installation script? > Then t/05setup_database.t needs to be rewritten in terms of it. Sure, I'll do that today. > I think the plugin order stuff is fucked. Certainly I'd expect ID to > be a unique column with a sequence on it and so specifying explicit > values into it will just lead to badness. An extra "order" column is > probably called for, and since we're no longer doing things with > Class::DBI we don't actually need that id field, so we may as well > just rename it. Sure, I was just using what was there. It doesn't really make a difference to me what the columns are called. I'm column agnostic. Columnly ambivalent. > cvs update ; perl Makefile.PL ; make ; make cover Oooh. Shiny. Should Devel::Cover now be a prereq? I'm happy either way. [ attempts to install Devel::Cover, find it requires 5.6.1 ] That'd be a no then, we shouldn't. Wonder why Siesta.pm is so low. Is it because we don't actually process anything in the tests? > Done. Cool. > I don't follow. Replys and bounces aren't actually hard, and instead > of subclassing you could just supply a new Plugin, so I don't see > quite where you're going with this. Basically my reasoning was this - we'll need to send mails to bounce and reply to stuff (for SimpleSig and Subscribe and stuff) and also when we actually want to send stuff at the end of the pipeline and I want to do another Send plugin that loops through all the users runs some plugins on them again just as a test. For all of those it would be nice just to be able to do $message->send() and have it work automatically and also cos then we wouldn't be duplicating code. For that we should abstract the code in Siesta/Plugin/Send.pm into a send function but if we're doing that we could do it as modules so that we could do Sendmail, SMTP, whatever. > >From a quick tour I took earlier, I think Siesta::Storage::DBI has > entirely too much logic in it now, as well as a chunk of fugly code > duplication, thoughts on this later. Yeah, it's starting to get crufty and uneditable. Sorry. Wasn't sure where else to stick the code. nacho has also got unbelievably big (800 lines or so ... [checks] 476 lines which aren't whitespace or comments). Suggestions gladly welcome. SimonThere's stuff above here
Generated at 13:56 on 01 Jul 2004 by mariachi 0.52