[prev] [thread] [next] [lurker] [Date index for 2002/09/24]
On Tue, Sep 24, 2002 at 01:04:34PM +0100, Simon Wistow wrote:
> Apart from some things (which I need to fix) most of what nacho is is
> error messages and presentation. For example
>
> sub show_users_list {
> my $list_id = shift || die "You must pass a list id to
> show_users_list\n";
> my $list = Siesta::List->new($list_id) || die "Invalid list id\n";
There's some refactoring you can do right there.
my $list = Siesta::List->new(shift) ...
and rely on Siesta::List's constructor to blow the appropriate chunks when
it is called with no data. Cos Siesta::List is checking parameters in all
its methods, right?
--
David Cantrell | Reprobate | http://www.cantrell.org.uk/david
Some people, when confronted with a problem, think ``I know, I'll use
regular expressions.'' Now they have two problems. -- jwz
There's stuff above here
Generated at 13:56 on 01 Jul 2004 by mariachi 0.52