Re: [siesta-dev] problem with Email::Valid in Siesta::Message

[prev] [thread] [next] [lurker] [Date index for 2002/10/10]

From: Simon Wistow
Subject: Re: [siesta-dev] problem with Email::Valid in Siesta::Message
Date: 11:08 on 10 Oct 2002
On Thu, Oct 10, 2002 at 11:02:51AM +0100, Richard Clamp said:
> On Thursday, Oct 10, 2002, at 09:45 Europe/London, Simon Wistow wrote:
> > On Thu, Oct 10, 2002 at 09:34:36AM +0100, Roger Burton West said:
> >> Side note: Is there any reason we don't use Mail::Address directly
> >> instead of Email::Valid (which depends on it)? That _will_ accept an
> >> address of the form that's causing problems, without complaint.
> 
> > I have no idea. I think we'd been drinking at the time that that
> > particular piece of code got written. I remember finding the module and
> > suggesting it with a frown on my face and Richard not being
> > particularly happy with it.
> 
> I disremember - I think maybe it was another module you'd found, but 
> *shurg*
> 
> This is what I've patched:

beat me to it by a matter of seconds :)

I was also going to have

# make sure we have a from line and a to line
my $to = $args{to} || $clone->from();
return 0 unless (defined $to);

my $from = $args{from} || $clone->to();
return 0 unless (defined $from);

$clone->to($to);
$clone->from($from);



There's stuff above here

Generated at 13:56 on 01 Jul 2004 by mariachi 0.52