Re: [siesta-dev] problem with Email::Valid in Siesta::Message

[prev] [thread] [next] [lurker] [Date index for 2002/10/10]

On Thursday, Oct 10, 2002, at 11:08 Europe/London, Simon Wistow wrote:
> beat me to it by a matter of seconds :)
>
> I was also going to have

Where?  Message->reply?

Ummm.

It strikes me that it would be much better to catch this in the Send:: 
module - probably by throwing an error.

> # make sure we have a from line and a to line
> my $to = $args{to} || $clone->from();
> return 0 unless (defined $to);

Argh - all those poor wasted bytes! :)

my $to = $args{to} || $clone->from;
return unless $to;

I strongly suspect '' and 0 aren't useful as email addresses, otherwise 
you've be writing:

my $to = defined $args{to} ? $args{to} : $clone->from;
return unless defined $to;

-- 
Richard Clamp <richardc@xxxxxxxxx.xxx>

• Simon Wistow 11:08 on 10 Oct 2002
  • Richard Clamp 11:16 on 10 Oct 2002

Generated at 13:56 on 01 Jul 2004 by mariachi 0.52