[prev] [thread] [next] [lurker] [Date index for 2003/04/13]
On Sun, Apr 13, 2003 at 10:58:26PM +0100, Simon Wistow wrote: > I've checked a first pass for Email::Folder (reading from various > different email repositories) into the siesta svn tree. I don't imagine > they'll stay there permanently but it seemed a good place for them Cool as. A couple of quick comments based on almost no looking at the code: MakeMaker MUST DIE. You're artificially prolonging it's reign of terror. If you need a starting point for a Build.PL, try the separate plugins and they have really simple ones. https://siesta.unixbeard.net/svn/trunk/Siesta-Plugin-CheckUser/Build.PL > E:F:DT does naive guessing of the folder type. Currently it's based on > the snippet of code from Email::LocalDelivery but I can imagine ti > getting more sophisticated later and, as such, it'd be better off in its > own module. I'm not in love with the name. In fact, I'm not in love with > the module but it's easier to roll back in than it is to extract out > later so ... Yeah. Depending on which way t'other Simon thinks about it, it could be an idea to move Email::LocalDelivery::type_of into Email::Folder, then just have a dependency on Email::Folder. > It needs tests. I'll work some up if I get the time over the next few days. > E:F reads from mbox's and maildirs. It needs to cope with rmail, mh and > the various mbox variants. It needs tests for maildirs. And the Maildir.pm checking in. Along with your test mbox. And a pony. -- Richard Clamp <richardc@xxxxxxxxx.xxx>
Generated at 13:56 on 01 Jul 2004 by mariachi 0.52