Re: [siesta-dev] stupidity

[prev] [thread] [next] [lurker] [Date index for 2002/09/09]

From: Simon Wistow
Subject: Re: [siesta-dev] stupidity
Date: 17:19 on 09 Sep 2002
On Mon, Sep 09, 2002 at 02:21:51PM +0100, Richard Clamp said:
> the api you're testing is sane.  I've just tried to debug the new
> failures[0] you added to the tests for the Plugins but can't keep the
> api for Storage->config and Plugin->config straight in my head.

It's actually fairly simple but I'm hogging somebody else's computer at
the moment.

I just had a brainfart yesterday and had it all fixed this morning by
about 7:30

> There's something about 4 positional parameters that need to be ''
> rather than undef for falseness that twists my noodle, and I can't
> shake the feeling that potential third-party Plugin authors won't get
> it either.

Actually the undef -> '' stuff is in there cos of the _get_rows stuff
which wouldn't have handled undefs very well.

There are lots of 

	$user_id ||= '';

type things left over from the stupidity yesterday and I'll remove them
and then maybe patch _get_rows to handle undef to NULL translation.

Plugin authors don't actually have to get their head round anything. A
message can optionally have a user object attached to it in the same way
that it has a list. All the plugin author has to do is

  $self->config($message, 'key')

to get a value or

  $self->config($message, 'key', $newvalue)

to set it.

Everything else is magically done for them.

Sorry about the config droppings in, I'll clean em up tomorrow.

: third time's a charm

There's stuff above here

Generated at 13:56 on 01 Jul 2004 by mariachi 0.52