Re: [siesta-dev] problem with Email::Valid in Siesta::Message

[prev] [thread] [next] [lurker] [Date index for 2002/10/10]

From: Simon Wistow
Subject: Re: [siesta-dev] problem with Email::Valid in Siesta::Message
Date: 09:45 on 10 Oct 2002
On Thu, Oct 10, 2002 at 09:34:36AM +0100, Roger Burton West said:
> ...or fail gracefully, which is the other option?

This is what we should do. 
 
> Side note: Is there any reason we don't use Mail::Address directly
> instead of Email::Valid (which depends on it)? That _will_ accept an
> address of the form that's causing problems, without complaint.

I have no idea. I think we'd been drinking at the time that that
particular piece of code got written. I remember finding the module and
suggesting it with a frown on my face and Richard not being
particularly happy with it.

> I agree with Gavin that there's no point in testing for an error
> condition if we aren't going to handle it.

This is true. In this case I suspect that the thing to do is something
like


$mail->from($args{from} || $mail->to() || $list->admin());

or something.

Simon


There's stuff above here

Generated at 13:56 on 01 Jul 2004 by mariachi 0.52