Re: [siesta-dev] Re: [siesta-commit] rev 601 - in trunk/siesta: t lib lib/Siesta lib/Siesta/Plugin

[prev] [thread] [next] [lurker] [Date index for 2003/04/01]

From: Richard Clamp
Subject: Re: [siesta-dev] Re: [siesta-commit] rev 601 - in trunk/siesta: t lib lib/Siesta lib/Siesta/Plugin
Date: 11:19 on 01 Apr 2003
On Tue, Apr 01, 2003 at 11:07:49AM +0100, Simon Wistow wrote:
> On Tue, Apr 01, 2003 at 09:05:19AM +0100, Richard Clamp said:
> > This change is addled.
> 
> > I'd suggest putting this file back as it was.
> 
> yes. or changing the 
> 
>    || "";
> 
> to
> 
>    or die "Some error\n";
> 
> possibly.

I know what I was suggesting :)

I don't think it's worth cluttering the code with tests for things
like $plugin->list not existing, or $list->post_address returning
false, since by definition that shalt not happen.  That you were
getting warnings before was just a side effect of 20fulltest.t being
sloppily written, which is my bad.

<aside>
I was having a minor crack-fuelled moment on the tube about maybe
doing some design-by-contract style stuff like this:

package Siesta::Plugin;
sub ASSERT_process {
    my $self = shift;
    assert($self->list); 
}

and a new testing dooberie that does symbol table badness to make
->ASSERT_process always run before ->process, when it's enabled.

But then this should/could probably be aspect oriented, so we can hook
all kinds of bondage into the system for testing/debugging purposes.
</aside>

But anyway, when I say 'put it back how it was', I mean exactly that.

-- 
Richard Clamp <richardc@xxxxxxxxx.xxx>

Generated at 13:56 on 01 Jul 2004 by mariachi 0.52