Re: patching CPAN bugs (was Re: [siesta-dev] and again for the archives)

[prev] [thread] [next] [lurker] [Date index for 2003/04/06]

From: Richard Clamp
Subject: Re: patching CPAN bugs (was Re: [siesta-dev] and again for the archives)
Date: 13:47 on 06 Apr 2003
On Fri, Apr 04, 2003 at 01:13:17PM +0100, Nicholas Clark wrote:
> I'm envisaging importing the source of any module when we find a need to
> change it, and keeping any local hacks under source control. This way
> anything we install is either vanilla third party releases, or something
> we can replicate from source control.

I think by internalising someone else's code we're skirting the edge
of rudeness through forking, but yes, we need to do something about
the issue.

Here's what I propose.  Add a new section to HACKING called, I dunno,
READ THIS DAMNIT where we can make reference to things like submitted
patches, as that makes it more clear about things that aren't the
original authors doing.  Compare my tiny Module::Build patch which mutated into this set
of changes

So, in the Module::Build and Email::Simple cases it's currently best to
point at their cvs repositories.  For Email::LocalDelivery::Maildir
there's a patch in rt, which is unapplied, but I'll write some failing
tests later to see if it helps things slide in.

If we do have to keep anything in subversion I think it should be
patches.  And then only when the author seems not to prefer trackers
like  Anything we can do to say "we did this, so don't
blame our new bug on the upstream guys" really.

Richard Clamp <>
There's stuff above here

Generated at 13:56 on 01 Jul 2004 by mariachi 0.52