[prev] [thread] [next] [lurker] [Date index for 2003/04/12]
On Sat, Apr 12, 2003 at 10:37:21PM +0100, nick@xxxx.xxx wrote:
> OK. Here is a patch to make mariachi use Email::Simple. I'm not convinced
> that it is correct. Also, I'm not convinced that it is faster. It seems
> to load much more quickly, but sort and particularly output generation are
> far slower, so it seems to be a net loss. I'm going to go to bed, and I'm
> not going to get a chance to look at this until at least Monday night. So
> anyone else is welcome to play.
I applied a modified version of this as #704. I don't see the
slowdown on threading now, but I do see the slowdown in generation. I
think that it can be solved by doing a little bit of caching early on
Eg. ->filename could be determined at load time for instance, rather
than the $x times now (once per index, and once per message it's a
thread with). Will fiddle with that later.
>
> I still have one of these:
>
> Use of uninitialized value in concatenation (.) or string at /usr/local/lib/perl5/site_perl/5.9.0/Email/Simple.pm line 208.
>
> That's here in sub _headers_as_string:
>
> $stuff .= _header_as_string($thing, $head{$thing});
Fixed in Email::Simple cvs.
> The output appears to be identical, apart from the hashes generated for the
> filenames.
Sweet, thanks.
--
Richard Clamp <richardc@xxxxxxxxx.xxx>
Generated at 13:56 on 01 Jul 2004 by mariachi 0.52