broken log function

[prev] [thread] [next] [lurker] [Date index for 2004/09/26]

Unless I'm unusually dyslexic today, function log() in Siesta.pm
should not be:

    print $logger "$date $message $level\n"
      if $level >= $config->log_level;

either that "if" should be an "unless", or that ">=" should
be a "<=".

<rant>
also, why that particular argument structure for the
log function? why not ($self, $level, @message) like
every other log function on the planet?
and why name the function "log" for that matter,
when there is a builtin function by that name
that takes the natural logarithm?
oh, and what's the point of $CONFIG_FILE in Config.pm
that nobody pays any attention to -- for example
if somebody wanted to actually change the value
of, say, log_level....
</rant>

thanks....

-mda

• broken log function Mark D. Anderson 02:24 on 26 Sep 2004
  • Re: [siesta-dev] broken log function Richard Clamp 09:43 on 27 Sep 2004
    • too deep to show

Generated at 22:00 on 09 Oct 2004 by mariachi 0.52